Skip to content

Wait for system maintenance page to load when rerunning the task#2615

Merged
labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom
25.7_fb_waitForMaintenancePageLoad
Aug 11, 2025
Merged

Wait for system maintenance page to load when rerunning the task#2615
labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom
25.7_fb_waitForMaintenancePageLoad

Conversation

@labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Aug 8, 2025

Rationale

ConfigureSystemMaintenancePage.runMaintenanceTask assumes that it has opened a new window when it waits for the pipeline job to complete. FileContentUploadTest.testCalculateFileRootSize actually triggers the system maintenance twice without closing the window. The causes the test to fail intermittently as failing to wait for page loads often does.

java.lang.AssertionError: Incorrect job status expected:<COMPLETE> but was:<null>
  at org.junit.Assert.fail(Assert.java:89)
  at org.junit.Assert.failNotEquals(Assert.java:835)
  at org.junit.Assert.assertEquals(Assert.java:120)
  at org.labkey.test.pages.pipeline.PipelineStatusDetailsPage.assertStatus(PipelineStatusDetailsPage.java:125)
  at org.labkey.test.pages.pipeline.PipelineStatusDetailsPage.waitForStatus(PipelineStatusDetailsPage.java:139)
  at org.labkey.test.pages.pipeline.PipelineStatusDetailsPage.waitForComplete(PipelineStatusDetailsPage.java:182)
  at org.labkey.test.pages.pipeline.PipelineStatusDetailsPage.waitForComplete(PipelineStatusDetailsPage.java:170)
  at org.labkey.test.pages.admin.ConfigureSystemMaintenancePage.runMaintenanceTask(ConfigureSystemMaintenancePage.java:34)
  at org.labkey.test.tests.filecontent.FileContentUploadTest.testCalculateFileRootSize(FileContentUploadTest.java:367)

Rather that updating the test to close the window, we can make the page more robust by waiting for a page load when necessary.

Related Pull Requests

Changes

  • Wait for system maintenance page to load when rerunning the task

@labkey-tchad labkey-tchad requested review from a team and labkey-chrisj and removed request for a team August 8, 2025 23:50
@labkey-tchad labkey-tchad merged commit 435a498 into release25.7-SNAPSHOT Aug 11, 2025
8 checks passed
@labkey-tchad labkey-tchad deleted the 25.7_fb_waitForMaintenancePageLoad branch August 11, 2025 19:29
This was referenced Aug 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@labkey-chrisj labkey-chrisj labkey-chrisj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-tchad @labkey-chrisj